Horton

Re: Removing support for COPY FROM STDIN in protocol version 2

Heikki Linnakangas <hlinnaka@iki.fi>

View thread View on postgr.es
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Michael Paquier <michael@paquier.xyz>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2021-02-04T15:47:05Z
Lists: pgsql-hackers 
On 04/02/2021 17:35, Tom Lane wrote:
> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
>> Yeah, the changes I was thinking about are all in libpq-int.h so that's
>> not really a problem.  But one enum in libpq-fe.h renumbers values, and
>> I think it's better to keep the old value labelled as "unused" to avoid
>> any changes.
> 
> Oh, yeah, can't do that.  libpq-fe.h probably shouldn't change at all;
> but certainly we can't renumber existing enum values there.

Ah, right, there's even a comment above the enum that says that's a no 
no. But yeah, fixing that, I see no need for .so version bump.

- Heikki

Commits

  1. Avoid extra newline in errors received in FE protocol version 2.

  2. Remove server and libpq support for old FE/BE protocol version 2.

  3. Handle reading of startup packet and authentication exchange after forking