Horton
Menu

Re: run pgindent on a regular basis / scripted manner

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jelte Fennema <postgres@jeltef.nl>, Michael Paquier <michael@paquier.xyz>, "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>, Robert Haas <robertmhaas@gmail.com>, Justin Pryzby <pryzby@telsasoft.com>, Andres Freund <andres@anarazel.de>, Noah Misch <noah@leadboat.com>, Peter Geoghegan <pg@bowt.ie>, Bruce Momjian <bruce@momjian.us>, Magnus Hagander <magnus@hagander.net>, Alvaro Herrera <alvherre@2ndquadrant.com>, Stephen Frost <sfrost@snowman.net>, Jesse Zhang <sbjesse@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Date: 2023-06-20T13:21:14Z
Lists: pgsql-hackers 
On 2023-06-20 Tu 09:08, Tom Lane wrote:
> Andrew Dunstan<andrew@dunslane.net>  writes:
>> On 2023-06-19 Mo 17:07, Tom Lane wrote:
>>> Is koel tracking the right repo?  It just spit up with a bunch of
>>> diffs that seem to have little to do with the commit it's claiming
>>> caused them:
>> Yeah, I changed it so that instead of just checking new commits it would
>> check the whole tree. The problem with the incremental approach is that
>> the next run it might turn green again but the issue would not have been
>> fixed.
> Ah.
>
>> I think this is a one-off issue. Once we clean up the tree the problem
>> would disappear and the commits it shows would be correct. I imaging
>> that's going to happen any day now?
> I can go fix the problems now that we know there are some (already).
> However, if what you're saying is that koel only checks recently-changed
> files, that's going to be pretty misleading in future too.  If people
> don't react to such reports right away, they'll disappear, no?
>
> 			


That's what would have happened if I hadn't changed the way it worked 
(and that's why I changed it). Now it doesn't just check recent commits, 
it checks the whole tree, and will stay red until the tree is fixed.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix comment from commit 22655aa231.

  2. Add a few recent commits to .git-blame-ignore-revs.

  3. Pre-beta2 mechanical code beautification.

  4. Pre-beta mechanical code beautification.

  5. Make agreed-on updates in perltidy options.

  6. Remove obsolete pgindent options --code-base and --build

  7. Integrate pg_bsd_indent into our build/test infrastructure.

  8. Sync pg_bsd_indent's copyright notices with Postgres practice.

  9. Import pg_bsd_indent sources.

  10. pgindent: filter files for the --commit option

  11. pgindent: more ways to find files to indent

  12. Fix pgindent --show-diff option.

  13. Add non-destructive modes to pgindent

  14. Initial pgindent run with pg_bsd_indent version 2.0.