Horton

Re: pgsql: Add TAP tests for pg_verify_checksums

Andrew Dunstan <andrew.dunstan@2ndquadrant.com>

View thread View on postgr.es
From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>, Michael Banck <michael.banck@credativ.de>, Andres Freund <andres@anarazel.de>, Postgres hackers <pgsql-hackers@postgresql.org>, Daniel Gustafsson <daniel@yesql.se>, Magnus Hagander <magnus@hagander.net>
Date: 2018-10-15T15:20:28Z
Lists: pgsql-hackers 

On 10/15/2018 11:05 AM, Tom Lane wrote:
> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>> We should fix this in PG11 rather than ship a broken utility. If
>> everyone is happy, I can apply this.
> At this point I'd be happier if you waited till after 11.0 wraps...
> there is no margin for error today.
>
> 			



OK. In that case should we note that the utility is broken on Windows?

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Fix issues with TAP tests of pg_verify_checksums

  2. Use whitelist to choose files scanned with pg_verify_checksums

  3. Add TAP tests for pg_verify_checksums

  4. Work around Msys weakness in Testlib.pm's command_like()