Horton

Re: Bug fix for psql's meta-command \ev

Ryoga Yoshida <bt23yoshidar@oss.nttdata.com>

View thread View on postgr.es
From: Ryoga Yoshida <bt23yoshidar@oss.nttdata.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Aleksander Alekseev <aleksander@timescale.com>, pgsql-hackers@lists.postgresql.org, Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Date: 2023-09-19T06:29:11Z
Lists: pgsql-hackers

Attachments

On 2023-09-19 12:53, Michael Paquier wrote:
> Adding a comment looks important to me once we consider the edit as a
> path that can fail and the edited query is only executed then reset
> when we have PSQL_CMD_NEWEDIT as status.  I would suggest the patch
> attached instead, taking care of the error case of this thread and the
> ones I've spotted.

Thank you everyone for the reviews. I fixed the patch for the error and 
also added a comment
. You can see attached file.

Ryoga Yoshida

Commits

  1. psql: Reset query buffer of \e, \ef and \ev on error