Horton

Re: [PATCH] Add `headerscheck` run_target to meson

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: Miłosz Bieniek <bieniek.milosz0@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2025-11-28T11:53:25Z
Lists: pgsql-hackers 
On 27.11.25 10:28, Miłosz Bieniek wrote:
> While reviewing a patch I noticed that we have a `make -s headerscheck` 
> but there is no equivalent in meson.
> I prepared a small patch that adds `headerscheck` and `cpluspluscheck` 
> targets.

This would be good to have, but I don't think your patch works.  It 
seems you need to add the srcdir and builddir command-line arguments to 
the invocations.

Commits

  1. headerscheck: Get CXXFLAGS from Makefile.global

  2. meson: Add headerscheck and cpluspluscheck targets

  3. meson: Add {perl|python}_includespec to generated Makefile.global