Re: [19] CREATE SUBSCRIPTION ... SERVER

Jeff Davis <pgsql@j-davis.com>

From: Jeff Davis <pgsql@j-davis.com>

To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>

Cc: Amit Kapila <amit.kapila16@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, Joe Conway <mail@joeconway.com>, pgsql-hackers@postgresql.org

Date: 2026-03-18T19:06:48Z

Lists: pgsql-hackers

Attachments

v23-0001-Temp-context-for-maybe_reread_subscription.patch (text/x-patch) patch v23-0001
v23-0002-Refactor-to-remove-ForeignServerName.patch (text/x-patch) patch v23-0002
v23-0003-Add-pg_dump-tests-related-to-CREATE-SUBSCRIPTION.patch (text/x-patch) patch v23-0003
v23-0004-Add-dependency-entry-for-FDW-connection-function.patch (text/x-patch) patch v23-0004

On Sat, 2026-03-14 at 15:55 -0700, Jeff Davis wrote:
> Attached series including patches to address Andres's and Amit's
> comments, too.

Committed two patches.

New patch 0004: fixes missing dependencies from the FDW to the
connection function. There's a related pre-existing issue with the
dependency from the FDW to the handler function, which I will post as a
separate backportable bugfix.

I'd still like to find a good way to add pg_dump tests. The only idea I
have now is to build the test function into core postgres (without
pg_proc entry), which might be worthwhile.

Regards,
	Jeff Davis

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Document new catalog columns, missed in commit 8185bb5347.
- 90630ec42939 19 (unreleased) landed
Refactor to remove ForeignServerName().
- 11f8018ee678 19 (unreleased) landed
GetSubscription(): use per-object memory context.
- f16f5d608ca6 19 (unreleased) landed
Fix dependency on FDW's connection function.
- 4a0b46b6e1e4 19 (unreleased) landed
ALTER SUBSCRIPTION ... SERVER test.
- 1c5bf1185af0 19 (unreleased) landed
Fix pg_dump for CREATE FOREIGN DATA WRAPPER ... CONNECTION.
- b71bf3b84570 19 (unreleased) landed
Clean up postgres_fdw/t/010_subscription.pl.
- f4af7849b3db 19 (unreleased) landed
CREATE SUBSCRIPTION ... SERVER.
- 8185bb534763 19 (unreleased) landed
Allow upgrades to preserve the full subscription's state.
- 9a17be1e244a 17.0 cited