Re: Sometimes the output to the stdout in Windows disappears
Alexander Law <exclusion@gmail.com>
From: Alexander Lakhin <exclusion@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Victor Spirin <v.spirin@postgrespro.ru>,
pgsql-hackers@lists.postgresql.org
Date: 2020-10-18T18:00:00Z
Lists: pgsql-hackers
17.10.2020 21:44, Tom Lane wrote: > I propose the attached patch. If this doesn't cause buildfarm problems, > perhaps we should back-patch it. Thank you! I've made a simple cmd script to reproduce problems seen on dory: https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=dory&br=HEAD FOR /L %%I IN (1,1,200) DO call :CHECK %%I GOTO :eof :CHECK echo iteration %1 call vcregress ecpgcheck IF %ERRORLEVEL% NEQ 0 GOTO ERR EXIT /B :ERR echo iteration %1 failed pause Without the fix I've got errors on iterations 43, 46, 128, 47, 14, 4, 27, which approximately corresponds to the ECPG-Check failure frequency on dory (for HEAD). With the fix all the 200 iterations passed as expected. Then I ran the loop again just to be sure and got: test thread/descriptor ... stderr FAILED 81 ms iteration 124 failed. diff -w -U3 .../src/interfaces/ecpg/test/expected/thread-descriptor.stderr .../src/interfaces/ecpg/test/results/thread-descriptor.stderr --- .../src/interfaces/ecpg/test/expected/thread-descriptor.stderr 2019-12-04 16:05:46 +0300 +++ .../src/interfaces/ecpg/test/results/thread-descriptor.stderr 2020-10-18 20:20:27 +0300 @@ -0,0 +1 @@ +SQL error: descriptor "mydesc" not found on line 31 It's interesting that all failures before the fix were with stdout, but this one is with stderr. I'm going to investigate this issue further. Best regards, Alexander
Commits
-
In libpq for Windows, call WSAStartup once and WSACleanup not at all.
- cdc7ace161d3 9.6.20 landed
- 883226441d67 11.10 landed
- 6acc31a201d8 9.5.24 landed
- 6670e91078b3 10.15 landed
- d2074daebe16 13.1 landed
- 407580aabb83 12.5 landed
- 7d00a6b2de8a 14.0 landed
-
Update the Winsock API version requested by libpq.
- d5a9a661fcd2 14.0 landed