Re: partitioned tables referenced by FKs

Amit Langote <langote_amit_f8@lab.ntt.co.jp>

From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>

To: jesper.pedersen@redhat.com, Alvaro Herrera <alvherre@2ndquadrant.com>

Cc: Pg Hackers <pgsql-hackers@postgresql.org>

Date: 2019-03-26T06:06:25Z

Lists: pgsql-hackers

Hi Jesper,

On 2019/03/22 22:01, Jesper Pedersen wrote:
> Hi Alvaro,
> 
> On 3/21/19 6:18 PM, Alvaro Herrera wrote:
>> On 2019-Mar-21, Jesper Pedersen wrote:
>>> pgbench -M prepared -f select.sql ....
>>>
>>> I'm seeing 82.64% spent in GetCachedPlan(). plan_cache_mode is auto.
>>
>> Hmm, I can't reproduce this at all ...  I don't even see GetCachedPlan
>> in the profile.  Do you maybe have some additional patch in your tree?
>>
> 
> No, with 7df159a62 and v7 compiled with "-O0 -fno-omit-frame-pointer" I
> still see it.
> 
> plan_cache_mode = auto
>   2394 TPS w/ GetCachePlan() @ 81.79%
> 
> plan_cache_mode = force_generic_plan
>  10984 TPS w/ GetCachePlan() @ 23.52%

Wouldn't you get the same numbers on HEAD too?  IOW, I'm not sure how the
patch here, which seems mostly about getting DDL in order to support
foreign keys on partitioned tables, would have affected the result of this
benchmark.  Can you clarify your intention of running this benchmark
against these patches?

Thanks,
Amit

Commits

Support foreign keys that reference partitioned tables
- f56f8f8da6af 12.0 landed
Fix partitioned index creation bug with dropped columns
- 7009f1a2df65 11.3 landed
- 126d63122232 12.0 landed
Improve psql's \d display of foreign key constraints
- 1af25ca0c2d9 12.0 cited
Fix dependency recording bug for partitioned PKs
- 7e7c57bbb2eb 12.0 landed
Add index_get_partition convenience function
- a6da0047158b 12.0 landed
Restore RI trigger sanity check
- 815b20ae0c6e 12.0 landed
- 04f9b449aa30 11.3 landed
Foreign keys on partitioned tables
- 3de241dba86f 11.0 cited