Re: Clarity in partial index example.
Jonathan S. Katz <jkatz@postgresql.org>
From: "Jonathan S. Katz" <jkatz@postgresql.org>
To: droptablestar@gmail.com, pgsql-docs@lists.postgresql.org,
PG Doc comments form <noreply@postgresql.org>
Date: 2019-04-03T22:00:18Z
Lists: pgsql-docs
Attachments
- 0001-Use-consistent-examples-of-queries-demonstrating-whe.patch (text/plain) patch 0001
On 4/3/19 4:20 PM, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/11/indexes-partial.html > Description: > > The example illustrating when a partial index can and cannot be used is a > little misleading. The query which can use the partial index is: > SELECT * > FROM access_log > WHERE url = '/index.html' AND client_ip = inet '212.78.10.32'; > > and the query which can't use the partial index is: > SELECT * > FROM access_log > WHERE client_ip = inet '192.168.100.23'; > > Maybe I am misunderstanding the concept here but url = '/index.html' doesn't > have any effect on this? If that's the case I would suggest either removing > it from the first query or adding it to the second query. You're correct, the url = '/index.html' does not affect if the partial index is used in the example. Based on how the example is set up, I'd propose using the "url" parameter in both examples. I've attached a patch that does this, with some additional wording around the examples. Thanks, Jonathan
Commits
-
Doc: clarify partial-index example.
- af052daec5aa 12.0 landed