Horton

Re: v16 fails to build w/ Visual Studio 2015

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: Andres Freund <andres@anarazel.de>, Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@postgresql.org
Date: 2023-06-07T21:34:09Z
Lists: pgsql-hackers 
On 07.06.23 23:21, Andres Freund wrote:
> On 2023-06-07 11:54:58 -0700, Noah Misch wrote:
>> Visual Studio 2015 version "14.0.25431.01 Update 3" has an apparent compiler
>> bug that causes the build to fail with "readfuncs.switch.c(522): fatal error
>> C1026: parser stack overflow, program too complex (compiling source file
>> src/backend/nodes/readfuncs.c)".  While I wouldn't mind revoking support for
>> Visual Studio 2015, changing the code to cope is easy.  See attached.
> 
> I don't see a point in trying to keep Visual Studio 2015 working. We have no
> automated testing for it, as evidenced by this issue. It seems quite possible
> we're going to hit such issues in other places.

Apparently, nobody has used it between Sat Jul 9 08:52:19 2022 and now?

Commits

  1. Make parseNodeString() C idiom compatible with Visual Studio 2015.

  2. Automatically generate node support functions