Re: SSL tests failing for channel_binding with OpenSSL <= 1.0.1

Jeff Davis <pgsql@j-davis.com>

From: Jeff Davis <pgsql@j-davis.com>
To: Tom Lane <tgl@sss.pgh.pa.us>, Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-09-30T18:08:20Z
Lists: pgsql-hackers
On Mon, 2019-09-30 at 09:37 -0400, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
> > On Fri, Sep 27, 2019 at 11:44:57AM +0900, Michael Paquier wrote:
> > > We need to do something similar to c3d41cc for the test, as per
> > > the
> > > attached.  I have tested that with OpenSSL 1.0.1 and 1.0.2 to
> > > stress
> > > both scenarios.
> > > Any objections to this fix?
> > Committed as a12c75a1.
> 
> The committed fix looks odd: isn't the number of executed tests the
> same in both code paths?  (I didn't try it yet.)

test_connect_fails actually runs two tests, one for the failing exit
code and one for the error message.

Regards,
	Jeff Davis





Commits

  1. Fix SSL test for libpq connection parameter channel_binding