Re: [patch] [doc] Clarify that signal functions have no feedback

Heikki Linnakangas <hlinnaka@iki.fi>

From: Heikki Linnakangas <hlinnaka@iki.fi>
To: "David G. Johnston" <david.g.johnston@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-11-18T08:32:03Z
Lists: pgsql-hackers
On 17/11/2020 21:50, David G. Johnston wrote:
> On Tue, Nov 17, 2020 at 6:13 AM Heikki Linnakangas <hlinnaka@iki.fi 
> <mailto:hlinnaka@iki.fi>> wrote:
>     You can use the <link
>     linkend="view-pg-file-settings">pg_file_settings</link> and <link
>     linkend="view-pg-hba-file-rules">pg_hba_file_rules</link> views to
>     check
>     the configuration files for possible errors, before reloading.
> 
> 
> I agree with adding "why" you want to check those links, and added a bit 
> about why doing so before reloading works, but the phrasing using "You" 
> seems out-of-place in this region of the documentation.

There are plenty of "you"s in the docs. Matter of taste, for sure, but 
I'd prefer more active voice. Me being stubborn, I pushed this using my 
wording. :-)

Thanks!

- Heikki



Commits

  1. docs: Clarify that signal functions have no feedback.