Re: More time spending with "delete pending"
Alexander Law <exclusion@gmail.com>
From: Alexander Lakhin <exclusion@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Tom Lane
<tgl@sss.pgh.pa.us>, Justin Pryzby <pryzby@telsasoft.com>
Date: 2021-07-12T06:06:01Z
Lists: pgsql-hackers
Hello Michael, 12.07.2021 08:52, Michael Paquier wrote: > On Mon, Jul 12, 2021 at 02:09:41PM +0900, Michael Paquier wrote: >> And fairywren, that uses MinGW, is unhappy: >> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=fairywren&dt=2021-07-12%2004%3A47%3A13 >> Looking at it now. > I am not sure what to do here to cool down MinGW, so the patch has > been reverted for now: > - Plain stat() is not enough to do a proper detection of the files > pending for deletion on MSVC, so reverting only the part with > microsoft_native_stat() is not going to help. > - We are going to need an evaluation of the stat() implementation in > MinGW and check if is it possible to rely on it more. If yes, we > could get away with more tweaks based on __MINGW32__/__MINGW64__. I'll take care of it and will prepare mingw-compatible patch tomorrow. Best regards, Alexander
Commits
-
Revert "Fix issues with Windows' stat() for files pending on deletion"
- 5e60237ad1b4 14.0 landed
- 2c9b46c090e7 15.0 landed
-
Fix issues with Windows' stat() for files pending on deletion
- de1510e2f5a1 14.0 landed
- 54fb8c7ddf15 15.0 landed