Horton

Re: Wrong statistics for size of XLOG_SWITCH during pg_waldump.

David Steele <david@pgmasters.net>

View thread View on postgr.es
From: David Steele <david@pgmasters.net>
To: Shinya11.Kato@nttdata.com, movead.li@highgo.ca
Cc: pgsql-hackers@postgresql.org, andres@anarazel.de, michael@paquier.xyz, ahsan.hadi@highgo.ca, horikyota.ntt@gmail.com
Date: 2021-03-18T14:26:03Z
Lists: pgsql-hackers 
On 1/7/21 2:55 AM, Shinya11.Kato@nttdata.com wrote:
>>But 0 value maybe looks strange, so in current version I show it like below:
>>Type N (%) Record size (%) FPI size (%) Combined size (%)
>>---- - --- ----------- --- -------- --- ------------- ---
>>...
>>XLOG/SWITCH_JUNK - ( -) 11006248 ( 72.26) - ( -) 11006248 ( 65.78)
>>Transaction/COMMIT 10 ( 0.03) 340 ( 0.00) 0 ( 0.00) 340 ( 0.00)
> 
> I just wanted to know why the "count" and "fpi_len" fields 0 are.
> So, it would be nice to have 0 values. Sorry for confusing you.

Kato, it's not clear to me if you were asking for - to be changed back to 0?

You marked the patch as Ready for Committer so I assume not, but it  
would be better to say clearly that you think this patch is ready for a  
committer to look at.

Regards,
-- 
-David
david@pgmasters.net

Commits

  1. pg_waldump: Fix bug in per-record statistics.