Horton

Re: Detect buffer underflow in get_th()

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: kuznetsovam@altlinux.org, pgsql-hackers@lists.postgresql.org
Cc: nickel@altlinux.org, egori@altlinux.org
Date: 2025-08-18T09:16:28Z
Lists: pgsql-hackers 
On 13.12.24 09:57, Alexander Kuznetsov wrote:
> Hello, ping?
> 
> 24.09.2024 17:52, Alexander Kuznetsov wrote:
>> Hello,
>>
>> is there anything else we can help with or discuss in order to apply 
>> this fix?
>>
>> 24.07.2024 18:53, Alexander Kuznetsov пишет:
>>>
>>> 24.07.2024 18:39, Peter Eisentraut wrote:
>>>> If it can't happen in practice, maybe an assertion would be enough?
>>>>
>>>
>>> In practice, the function should not receive non-numeric strings 
>>> either; however, since there is an exception in place for such cases, 
>>> I thought it would be good to add a check for zero-length input in a 
>>> similar manner.
>>>
>>> But of course it's open for discussion and team decision whether this 
>>> should be addressed as an assertion or handled differently.

After some further (internal) consultations, I have committed your fix 
as an assertion.  Thanks.

Commits

  1. Detect buffer underflow in get_th()