Horton

Re: Remove PointerIsValid()

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: Jacob Champion <jacob.champion@enterprisedb.com>, Robert Haas <robertmhaas@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-09-24T15:05:02Z
Lists: pgsql-hackers 
On 17.09.25 18:26, Jacob Champion wrote:
> On Tue, Sep 16, 2025 at 10:21 PM Peter Eisentraut <peter@eisentraut.org> wrote:
>>
>> I think there is agreement that the PointerIsValid() macro is pretty
>> useless.  This patch proposes to remove it.  There have been a few
>> recent mini-discussions in other threads that appear to support this. [0][1]
> 
> Patch LGTM, and I like your chosen balance of the two replacements.

Thanks, pushed as is.  (Some people appeared to have stylistic 
preferences one way or another, but there was nothing specific proposed. 
  Follow-up patches could be entertained, of course.)

Commits

  1. Remove PointerIsValid()