Re: Set appropriate processing mode for auxiliary processes.

Heikki Linnakangas <hlinnaka@iki.fi>

From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Xing Guo <higuoxing@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2024-05-09T14:13:14Z
Lists: pgsql-hackers
On 09/05/2024 16:12, Xing Guo wrote:
> Hi hackers,
> 
> After several refactoring iterations, auxiliary processes are no
> longer initialized from the bootstrapper. I think using the
> InitProcessing mode for initializing auxiliary processes is more
> appropriate.

At first I was sure this was introduced by my refactorings in v17, but 
in fact it's been like this forever. I agree that InitProcessing makes 
much more sense. The ProcessingMode variable is initialized to 
InitProcessing, so I think we can simply remove that line from 
AuxiliaryProcessMainCommon(). There are existing 
"SetProcessingMode(InitProcessing)" calls in other Main functions too 
(AutoVacLauncherMain, BackgroundWorkerMain, etc.), and I think those can 
also be removed.

-- 
Heikki Linnakangas
Neon (https://neon.tech)




Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Remove redundant SetProcessingMode(InitProcessing) calls

  2. Move bgworker specific logic to bgworker.c