Horton

Thread

Commits

  1. doc: Fix incorrect description of INCLUDING COMMENTS in CREATE FOREIGN TABLE.

  2. Add support for LIKE in CREATE FOREIGN TABLE

  1. Fix inaccurate mention of index comments in CREATE FOREIGN TABLE docs

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2025-06-18T05:34:55Z

    Hi,

Commit 302cf157592 added support for LIKE in CREATE FOREIGN TABLE.
In this feature, since indexes are not created for foreign tables,
comments on indexes are not copied either.

However, the CREATE FOREIGN TABLE docs incorrectly states that
index comments are copied when using INCLUDING COMMENTS, as shown below:

     ------------------------------
     INCLUDING COMMENTS
     Comments for the copied columns, constraints, and indexes will be copied.
     ------------------------------

This isn't accurate for foreign tables, so we should remove the mention
of indexes. Patch attached.

Regards,

-- 
Fujii Masao
NTT DATA Japan Corporation

  2. Re: Fix inaccurate mention of index comments in CREATE FOREIGN TABLE docs

    Michael Paquier <michael@paquier.xyz> — 2025-06-18T06:50:23Z

    On Wed, Jun 18, 2025 at 02:34:55PM +0900, Fujii Masao wrote:
> Commit 302cf157592 added support for LIKE in CREATE FOREIGN TABLE.
> In this feature, since indexes are not created for foreign tables,
> comments on indexes are not copied either.

Good point.  This doc fix sounds fine to me.
--
Michael

  3. Re: Fix inaccurate mention of index comments in CREATE FOREIGN TABLE docs

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2025-06-18T07:55:56Z

    
On 2025/06/18 15:50, Michael Paquier wrote:
> On Wed, Jun 18, 2025 at 02:34:55PM +0900, Fujii Masao wrote:
>> Commit 302cf157592 added support for LIKE in CREATE FOREIGN TABLE.
>> In this feature, since indexes are not created for foreign tables,
>> comments on indexes are not copied either.
> 
> Good point.  This doc fix sounds fine to me.

Thanks for the review! I will commit the patch barring any other objections.

Regards,

-- 
Fujii Masao
NTT DATA Japan Corporation

  4. Re: Fix inaccurate mention of index comments in CREATE FOREIGN TABLE docs

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2025-06-19T00:17:40Z

    
On 2025/06/18 16:55, Fujii Masao wrote:
> 
> 
> On 2025/06/18 15:50, Michael Paquier wrote:
>> On Wed, Jun 18, 2025 at 02:34:55PM +0900, Fujii Masao wrote:
>>> Commit 302cf157592 added support for LIKE in CREATE FOREIGN TABLE.
>>> In this feature, since indexes are not created for foreign tables,
>>> comments on indexes are not copied either.
>>
>> Good point.  This doc fix sounds fine to me.
> 
> Thanks for the review! I will commit the patch barring any other objections.

I've pushed the patch. Thanks!

Regards,

-- 
Fujii Masao
NTT DATA Japan Corporation

  5. Re: Fix inaccurate mention of index comments in CREATE FOREIGN TABLE docs

    Michael Paquier <michael@paquier.xyz> — 2025-06-19T01:21:22Z

    On Wed, Jun 18, 2025 at 04:55:56PM +0900, Fujii Masao wrote:
> Thanks for the review! I will commit the patch barring any other objections.

Thanks.
--
Michael