Remove IndexInfo.ii_OpclassOptions field

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>

To: pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2023-08-24T06:57:58Z

Lists: pgsql-hackers

Attachments

0001-Remove-IndexInfo.ii_OpclassOptions-field.patch (text/plain) patch 0001
0002-Remove-unused-include.patch (text/plain) patch 0002
0003-Remove-RelationGetIndexRawAttOptions.patch (text/plain) patch 0003

During some refactoring I noticed that the field 
IndexInfo.ii_OpclassOptions is kind of useless.  The IndexInfo struct is 
notionally an executor support node, but this field is not used in the 
executor or by the index AM code.  It is really just used in DDL code in 
index.c and indexcmds.c to pass information around locally.  For that, 
it would be clearer to just use local variables, like for other similar 
cases.  With that change, we can also remove 
RelationGetIndexRawAttOptions(), which only had one caller left, for 
which it was overkill.

Commits

Remove IndexInfo.ii_OpclassOptions field
- 784162357130 17.0 landed
Remove RelationGetIndexRawAttOptions()
- 5e4282772a56 17.0 landed
Remove unused include
- eb36c6ac8478 17.0 landed