Horton

Re: PGPROC alignment (was Re: pgsql: Separate RecoveryConflictReasons from procsignals)

Heikki Linnakangas <hlinnaka@iki.fi>

View thread View on postgr.es
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2026-02-20T21:01:33Z
Lists: pgsql-hackers 
On 11/02/2026 06:40, Bertrand Drouvot wrote:
> On Tue, Feb 10, 2026 at 10:53:58PM +0200, Heikki Linnakangas wrote:
> 0003:
> 
> 1/ There is one missing change in PrintLockQueue() ("links" is still used, and
> that should be replaced by "waitLink").
> 
> 2/ change the comment on top of ProcWakeup?
> 
> "
> /*
>   * ProcWakeup -- wake up a process by setting its latch.
>   *
>   *   Also remove the process from the wait queue and set its links invalid.
> "
> 
> s/links/waitLink/?

Fixed those and pushed this "Split PGPROC 'links' field into two, for 
clarity" patch. Thanks for the review!

- Heikki

Commits

  1. Use C11 alignas in typedef definitions

  2. Align PGPROC to cache line boundary

  3. Rearrange fields in PGPROC, for clarity

  4. Split PGPROC 'links' field into two, for clarity

  5. Remove useless store to local variable

  6. Separate RecoveryConflictReasons from procsignals