Re: [POC] Fast COPY FROM command for the table with foreign partitions

Alexey Kondratov <a.kondratov@postgrespro.ru>

From: Alexey Kondratov <a.kondratov@postgrespro.ru>
To: Andrey Lepikhov <a.lepikhov@postgrespro.ru>
Cc: Amit Langote <amitlangote09@gmail.com>, Ashutosh Bapat <ashutosh.bapat@2ndquadrant.com>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, Etsuro Fujita <etsuro.fujita@gmail.com>, PostgreSQL-Dev <pgsql-hackers@postgresql.org>
Date: 2020-07-28T07:54:22Z
Lists: pgsql-hackers
On 2020-07-28 03:33, Andrey Lepikhov wrote:
> 27.07.2020 21:34, Alexey Kondratov пишет:
>> Hi Andrey,
>> 
>> On 2020-07-23 09:23, Andrey V. Lepikhov wrote:
>>> On 7/16/20 2:14 PM, Amit Langote wrote:
>>>> Amit Langote
>>>> EnterpriseDB: http://www.enterprisedb.com
>>>> 
>>> 
>>> Version 5 of the patch. With changes caused by Amit's comments.
>> 
>> Just got a segfault with your v5 patch by deleting from a foreign 
>> table. It seems that ShutdownForeignScan inside node->fdwroutine 
>> doesn't have a correct pointer to the required function.
>> 
>> I haven't had a chance to look closer on the code, but you can easily 
>> reproduce this error with the attached script (patched Postgres 
>> binaries should be available in the PATH). It works well with master 
>> and fails with your patch applied.
> 
> I used master a3ab7a707d and v5 version of the patch with your script.
> No errors found. Can you check your test case?

Yes, my bad. I forgot to re-install postgres_fdw extension, only did it 
for postgres core, sorry for disturb.


Regards
-- 
Alexey Kondratov

Postgres Professional https://www.postgrespro.com
Russian Postgres Company



Commits

  1. Allow batch insertion during COPY into a foreign table.

  2. postgres_fdw: Disable batch insertion when there are WCO constraints.

  3. Enforce foreign key correctly during cross-partition updates

  4. Fix permission checks on constraint violation errors on partitions.

  5. Fix compilation of uuid-ossp