Horton

Re: [HACKERS] GSoC 2017 : Patch for predicate locking in Gist index

Teodor Sigaev <teodor@sigaev.ru>

View thread View on postgr.es
From: Teodor Sigaev <teodor@sigaev.ru>
To: Shubham Barai <shubhambaraiss@gmail.com>
Cc: Alexander Korotkov <a.korotkov@postgrespro.ru>, Andrey Borodin <x4mmm@yandex-team.ru>, Andrew Borodin <amborodin86@gmail.com>, Heikki Linnakangas <hlinnaka@iki.fi>, pgsql-hackers <pgsql-hackers@postgresql.org>, Kevin Grittner <kgrittn@gmail.com>
Date: 2018-03-27T07:53:12Z
Lists: pgsql-hackers

Attachments

Hi!

> Now it looks good for me.  I'm marking it "Ready for committer".

I have a question: why do not CheckForSerializableConflictIn() move  into 
begining of gistplacetopage()? Seems, it is the single function which actually 
changes page and all predicate locking stuff will be placed in single function...

See attached version of patch.
-- 
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
                                                    WWW: http://www.sigaev.ru/

Commits

  1. Add predicate locking for GiST