Re: badly calculated width of emoji in psql
Laurenz Albe <laurenz.albe@cybertec.at>
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Michael Paquier <michael@paquier.xyz>, Jacob Champion
<pchampion@vmware.com>
Cc: "pavel.stehule@gmail.com" <pavel.stehule@gmail.com>, "horikyota.ntt@gmail.com" <horikyota.ntt@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2021-07-19T11:13:57Z
Lists: pgsql-hackers
On Mon, 2021-07-19 at 16:46 +0900, Michael Paquier wrote: > > In your opinion, would the current one-line patch proposal make things > > strictly better than they are today, or would it have mixed results? > > I'm wondering how to help this patch move forward for the current > > commitfest, or if we should maybe return with feedback for now. > > Based on the following list, it seems to me that [u+1f300,u+0x1faff] > won't capture everything, like the country flags: > http://www.unicode.org/emoji/charts/full-emoji-list.html That could be adapted; the question is if the approach as such is desirable or not. This is necessarily a moving target, at the rate that emojis are created and added to Unicode. My personal feeling is that something simple and perhaps imperfect as my one-liner that may miss some corner cases would be ok, but anything that saps more performance or is complicated would not be worth the effort. Yours, Laurenz Albe
Commits
-
Extend collection of Unicode combining characters to beyond the BMP
- 5bc429aacb37 15.0 landed
-
Update display widths as part of updating Unicode
- bab982161e05 15.0 landed
-
Revert "Rename unicode_combining_table to unicode_width_table"
- 1563ecbc1be8 15.0 landed
-
Change mbbisearch to return the character range
- 78ab944cd4b9 15.0 landed