Horton

Re: Simplifying our Trap/Assert infrastructure

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Nathan Bossart <nathandbossart@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org
Date: 2022-10-31T09:02:35Z
Lists: pgsql-hackers

Attachments

On 31.10.22 01:04, Michael Paquier wrote:
> On Fri, Oct 28, 2022 at 09:36:23AM +0200, Peter Eisentraut wrote:
>> Would there be a use for that?  It's currently only used in the atomics
>> code.
> 
> Yep, but they would not trigger when using atomics in the frontend
> code.  We don't have any use for that in core on HEAD, still that
> could be useful for some external frontend code?  Please see the
> attached.

I don't think we need separate definitions for frontend and backend, 
since the contained Assert() will take care of the difference.  So the 
attached would be simpler.

Commits

  1. Make AssertPointerAlignment available to frontend code

  2. Remove AssertArg and AssertState

  3. Simplify our Assert infrastructure a little.