Re: Corrupted btree index on HEAD because of covering indexes

Teodor Sigaev <teodor@sigaev.ru>

From: Teodor Sigaev <teodor@sigaev.ru>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Alexander Korotkov <a.korotkov@postgrespro.ru>, Michael Paquier <michael@paquier.xyz>, Postgres hackers <pgsql-hackers@postgresql.org>, Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
Date: 2018-04-23T12:57:34Z
Lists: pgsql-hackers
Thank you, pushed

> I see your point. Maybe don't have the newline between the get and
> set, though, to match the existing style. And, the note about the
> assertion seems unnecessary.
Removed newline and note

> "Get/set leaf page highkey's link. During the second phase of
> deletion, the target leaf page's high key may point to an ancestor
> page (at all other times, the leaf level high key's link is not used).
> See the nbtree README for full details."
Changed as you suggested.


-- 
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
                                                    WWW: http://www.sigaev.ru/


Commits

  1. Add missing and dangling downlink checks to amcheck

  2. Fix wrong validation of top-parent pointer during page deletion in Btree.

  3. Add integrity-checking functions to pg_visibility.

  4. Make the handling of interrupted B-tree page splits more robust.