Horton

Thread

Commits

  1. Improve tab-completion for TRUNCATE.

  2. Fix typo

  1. [PATCH] Feature improvement for TRUNCATE tab completion.

    miyake_kouta <miyake_kouta@oss.nttdata.com> — 2021-02-22T07:04:10Z

    Hi.

I created a patch which improves psql's TRUNCATE tab completion.
Current tab completion can complement only a table name to be truncated.
This patch enables psql to complement other keywords related to 
TRUNCATE.

Regards.
Kota Miyake

  2. Re: [PATCH] Feature improvement for TRUNCATE tab completion.

    Muhammad Usama <m.usama@gmail.com> — 2021-02-22T16:44:03Z

    The following review has been posted through the commitfest application:
make installcheck-world:  not tested
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            not tested

Other than "Hunk #1 succeeded at 3832 (offset 33 lines)." message while applying the patch to
current master branch (commit 6a03369a71d4a7dc5b8d928aab775ddd28b72494) I found no issue with the patch.

The new status of this patch is: Ready for Committer

  3. Re: [PATCH] Feature improvement for TRUNCATE tab completion.

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2021-02-24T03:59:34Z

    
On 2021/02/23 1:44, Muhammad Usama wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world:  not tested
> Implements feature:       tested, passed
> Spec compliant:           tested, passed
> Documentation:            not tested
> 
> Other than "Hunk #1 succeeded at 3832 (offset 33 lines)." message while applying the patch to
> current master branch (commit 6a03369a71d4a7dc5b8d928aab775ddd28b72494) I found no issue with the patch.
> 
> The new status of this patch is: Ready for Committer

OK, so barring any objection, I will commit this patch.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

  4. Re: [PATCH] Feature improvement for TRUNCATE tab completion.

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2021-02-25T09:22:44Z

    
On 2021/02/24 12:59, Fujii Masao wrote:
> 
> 
> On 2021/02/23 1:44, Muhammad Usama wrote:
>> The following review has been posted through the commitfest application:
>> make installcheck-world:  not tested
>> Implements feature:       tested, passed
>> Spec compliant:           tested, passed
>> Documentation:            not tested
>>
>> Other than "Hunk #1 succeeded at 3832 (offset 33 lines)." message while applying the patch to
>> current master branch (commit 6a03369a71d4a7dc5b8d928aab775ddd28b72494) I found no issue with the patch.
>>
>> The new status of this patch is: Ready for Committer
> 
> OK, so barring any objection, I will commit this patch.

Pushed. Thanks!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION