Horton

Re: [HACKERS] Time to change pg_regress diffs to unified by default?

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Christoph Berg <myon@debian.org>, Noah Misch <noah@leadboat.com>, Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org
Date: 2019-02-20T10:20:50Z
Lists: pgsql-hackers 
On 2019-01-03 12:16, Peter Eisentraut wrote:
> On 03/01/2019 10:39, Christoph Berg wrote:
>> It will especially say which _alternate.out file was used, which seems
>> like a big win. So +1.
> 
> It already shows that in the existing diff output header.
> 
> Although if you have a really long absolute path, it might be hard to
> find it.  So perhaps the attached patch to make it more readable.

Any objections to this change?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. pg_regress: Don't use absolute paths for the diff

  2. Use standard diff separator for regression.diffs