Re: some LLVM function checks missing in meson

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>
To: Heikki Linnakangas <hlinnaka@iki.fi>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2024-04-17T08:53:49Z
Lists: pgsql-hackers
On 13.04.24 10:25, Heikki Linnakangas wrote:
> There's also this in llvmjit.c:
> 
>>         if (llvm_opt3_orc)
>>         {
>> #if defined(HAVE_DECL_LLVMORCREGISTERPERF) && 
>> HAVE_DECL_LLVMORCREGISTERPERF
>>             if (jit_profiling_support)
>>                 LLVMOrcUnregisterPerf(llvm_opt3_orc);
>> #endif
>>             LLVMOrcDisposeInstance(llvm_opt3_orc);
>>             llvm_opt3_orc = NULL;
>>         }
>>
>>         if (llvm_opt0_orc)
>>         {
>> #if defined(HAVE_DECL_LLVMORCREGISTERPERF) && 
>> HAVE_DECL_LLVMORCREGISTERPERF
>>             if (jit_profiling_support)
>>                 LLVMOrcUnregisterPerf(llvm_opt0_orc);
>> #endif
>>             LLVMOrcDisposeInstance(llvm_opt0_orc);
>>             llvm_opt0_orc = NULL;
>>         }
>>     }
> 
> The autoconf test that set HAVE_DECL_LLVMORCREGISTERPERF was removed in 
> commit e9a9843e13. I believe that's a leftover that should also have 
> been removed.

Right, that was clearly forgotten.  I have removed the dead code.



Commits

  1. meson: Add some missing LLVM function checks

  2. Remove dead code

  3. LLVMJIT: Adapt to API changes in gdb and perf support.