Horton

Thread

Commits

  1. Remove unused function declaration

  1. Extra code in commit_ts.h

    Andrei Lepikhov <a.lepikhov@postgrespro.ru> — 2021-08-03T09:36:34Z

    Hi,

I found two extra code lines in commit_ts.h (see attachment).
They confused me during exploring of the code. If they still needed, may 
be add some comments?

-- 
regards,
Andrey Lepikhov
Postgres Professional

  2. Re: Extra code in commit_ts.h

    David Rowley <dgrowleyml@gmail.com> — 2021-08-03T10:16:37Z

    On Tue, 3 Aug 2021 at 21:36, Andrey V. Lepikhov
<a.lepikhov@postgrespro.ru> wrote:
> I found two extra code lines in commit_ts.h (see attachment).
> They confused me during exploring of the code. If they still needed, may
> be add some comments?

Going by:

$ git config --global diff.renamelimit 1000
$ git diff 73c986adde5~1.. | grep check_track_commit_timestamp
+extern bool check_track_commit_timestamp(bool *newval, void **extra,

that function has never been defined.

David

  3. Re: Extra code in commit_ts.h

    Andrei Lepikhov <a.lepikhov@postgrespro.ru> — 2021-08-03T11:12:01Z

    On 3/8/21 15:16, David Rowley wrote:
> it diff 73c986adde5~1.. | grep check_track_commit_timestamp
I think this is waste code. May be delete it?

-- 
regards,
Andrey Lepikhov
Postgres Professional

  4. Re: Extra code in commit_ts.h

    David Rowley <dgrowleyml@gmail.com> — 2021-08-03T12:02:17Z

    On Tue, 3 Aug 2021 at 23:12, Andrey Lepikhov <a.lepikhov@postgrespro.ru> wrote:
>
> On 3/8/21 15:16, David Rowley wrote:
> > it diff 73c986adde5~1.. | grep check_track_commit_timestamp
> I think this is waste code. May be delete it?

Yeah, I think it can be safely removed.  I can do so unless someone
thinks otherwise.

David

  5. Re: Extra code in commit_ts.h

    David Rowley <dgrowleyml@gmail.com> — 2021-08-08T11:29:27Z

    On Wed, 4 Aug 2021 at 00:02, David Rowley <dgrowleyml@gmail.com> wrote:
> Yeah, I think it can be safely removed.  I can do so unless someone
> thinks otherwise.

Pushed.

David