Re: psql tab-complete
Victor Spirin <v.spirin@postgrespro.ru>
From: Victor Spirin <v.spirin@postgrespro.ru>
To: pgsql-hackers@lists.postgresql.org
Date: 2019-10-25T08:57:18Z
Lists: pgsql-hackers
Attachments
- nargs.patch (text/plain) patch
This patch resolved one problem in the tab-complete.c on MSVC. The VA_ARGS_NARGS macros now work correctly on Windows. Victor Spirin Postgres Professional:http://www.postgrespro.com The Russian Postgres Company 25.10.2019 0:53, Victor Spirin пишет: > Yes, I found, that VA_ARGS_NARGS(__ VA_ARGS__) macros always return 1 > on Windows. > > Victor Spirin > Postgres Professional:http://www.postgrespro.com > The Russian Postgres Company > > 25.10.2019 0:48, Tom Lane пишет: >> Victor Spirin <v.spirin@postgrespro.ru> writes: >>> I found some problem with tab-complete in the 12 version. I checked >>> this in the Windows. >> This change seems to break the case intended by the comment, >> ie given the context >> >> SELECT * FROM tablename WHERE <tab> >> >> we want to offer the columns of "tablename" as completions. >> >> I'd be the first to agree that that's completely lame, as there >> are any number of related cases it fails to cover ... but this >> patch isn't making it better. >> >> regards, tom lane >> >> > >
Commits
-
Add work-around for VA_ARGS_NARGS() on MSVC.
- 3f28bd7337d7 16.0 landed