Horton

Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file

David Steele <david@pgmasters.net>

View thread View on postgr.es
From: David Steele <david@pgmasters.net>
To: Stephen Frost <sfrost@snowman.net>
Cc: Nathan Bossart <nathandbossart@gmail.com>, Chapman Flack <chap@anastigmatix.net>, Magnus Hagander <magnus@hagander.net>, pgsql-hackers@lists.postgresql.org
Date: 2022-04-05T16:06:08Z
Lists: pgsql-hackers 
On 4/5/22 11:25 AM, Stephen Frost wrote:
> 
> Please find attached an updated patch + commit message.  Mostly, I just
> went through and did a bit more in terms of updating the documentation
> and improving the comments (there were some places that were still
> worrying about the chance of a 'stray' backup_label file existing, which
> isn't possible any longer), along with some additional testing and
> review.  This is looking pretty good to me, but other thoughts are
> certainly welcome.  Otherwise, I'm hoping to commit this tomorrow.

I have reviewed the changes and they look good. I also ran the new patch 
through pgbackrest regression with no issues.

Regards,
-- 
-David
david@pgmasters.net

Commits

  1. Remove duplicated word in comment of basebackup.c