Horton

Re: repeat() function, CHECK_FOR_INTERRUPTS(), and unlikely()

Joe Conway <mail@joeconway.com>

View thread View on postgr.es
From: Joe Conway <mail@joeconway.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL-development <pgsql-hackers@postgreSQL.org>
Date: 2020-06-05T20:53:01Z
Lists: pgsql-hackers 
On 6/4/20 5:20 PM, Alvaro Herrera wrote:
> On 2020-May-28, Joe Conway wrote:
> 
>> I backpatched and pushed the changes to the repeat() function. Any other
>> opinions regarding backpatch of the unlikely() addition to CHECK_FOR_INTERRUPTS()?
> 
> We don't use unlikely() in 9.6 at all, so I would stop that backpatching
> at 10 anyhow.  (We did backpatch unlikely()'s definition afterwards.)


Correct you are -- thanks for the heads up! Pushed to REL_10_STABLE and later.

Joe

-- 
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development

Commits

  1. Add unlikely() to CHECK_FOR_INTERRUPTS()

  2. Add CHECK_FOR_INTERRUPTS() to the repeat() function