Horton

Re: Psql meta-command conninfo+

Pavel Luzanov <p.luzanov@postgrespro.ru>

View thread View on postgr.es
From: Pavel Luzanov <p.luzanov@postgrespro.ru>
To: Maiquel Grassi <grassi@hotmail.com.br>, Nathan Bossart <nathandbossart@gmail.com>
Cc: Erik Wienhold <ewie@ewie.name>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2024-02-08T11:01:55Z
Lists: pgsql-hackers 
Hi,

On 07.02.2024 23:13, Maiquel Grassi wrote:

> Regarding the "system_user" function, as it is relatively new, I added 
> the necessary handling to avoid conflicts with versions lower than 
> version 16.
>
Yes, that's rights.

A couple of doubts about the implementation details.
But keep in mind that I'm not very good at programming in the C language.
I hope for the help of more experienced developers.


1.
+			if (db == NULL)
+				printf(_("You are currently not connected to a database.\n"));

This check is performed for \conninfo, but not for \conninfo+.


2.
Some values (address, socket) are evaluated separately for \conninfo
(via C functions) and for \conninfo+ (via sql functions).
It may be worth evaluating them in one place. But I'm not sure about that.

The final version of the patch will require changes to the documentation and tests.

-- 
Pavel Luzanov
Postgres Professional:https://postgrespro.com

Commits

  1. psql: Change new \conninfo to use SSL instead of TLS

  2. Change \conninfo to use tabular format

  3. Update extension lookup routines to use the syscache

  4. Improve COPY TO performance when server and client encodings match

  5. doc: Remove superfluous bracket in synopsis

  6. Remove psql support for server versions preceding 9.2.