Re: Detect buffer underflow in get_th()

24.07.2024 18:39, Peter Eisentraut wrote:
> If it can't happen in practice, maybe an assertion would be enough?
>

In practice, the function should not receive non-numeric strings either; however, since there is an exception in place for such cases, I thought it would be good to add a check for zero-length input in a similar manner.

But of course it's open for discussion and team decision whether this should be addressed as an assertion or handled differently.

-- 
Best regards,
Alexander Kuznetsov