Re: remove pg_restrict workaround

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-10-29T07:03:53Z
Lists: pgsql-hackers
On 15.10.25 15:58, Tom Lane wrote:
> Peter Eisentraut <peter@eisentraut.org> writes:
>> When in C11 mode, MSVC supports the standard "restrict" keyword, so we
>> don't need the workaround with using "pg_restrict" instead anymore.
>> (Just for clarification, restrict is a C99 feature, but MSVC only
>> accepts it properly in C11 mode.)  So I'm proposing to remove that
>> workaround here, so that code can use the standard restrict keyword
>> without having to worry about the alternative spelling.
> 
> Won't this break extensions that are using pg_restrict?  Sure, they
> could update their code, but then maybe it wouldn't work anymore
> against previous branches.  Seems like it'd be better to leave
> pg_restrict in place (for awhile anyway) but always #define it
> as "restrict".  I don't mind ceasing to use it within our own tree
> though.

Committed with a backward compatibility define.




Commits

  1. Revert "Replace pg_restrict by standard restrict"

  2. Replace pg_restrict by standard restrict

  3. Remove meaninglist restrict qualifiers