Re: Better shared data structure management and resizable shared data structures
Heikki Linnakangas <hlinnaka@iki.fi>
Attachments
- v12-0001-Move-some-code-from-shmem.c-and-shmem.h.patch (text/x-patch) patch v12-0001
- v12-0002-Introduce-a-new-mechanism-for-registering-shared.patch (text/x-patch) patch v12-0002
- v12-0003-Add-test-module-to-test-after-startup-shmem-allo.patch (text/x-patch) patch v12-0003
- v12-0004-Convert-pg_stat_statements-to-use-the-new-shmem-.patch (text/x-patch) patch v12-0004
- v12-0005-Introduce-registry-of-built-in-subsystems.patch (text/x-patch) patch v12-0005
- v12-0006-Convert-lwlock.c-to-use-the-new-shmem-allocation.patch (text/x-patch) patch v12-0006
- v12-0007-Use-the-new-shmem-allocation-function-in-a-few-c.patch (text/x-patch) patch v12-0007
- v12-0008-Refactor-shmem-initialization-code-in-predicate..patch (text/x-patch) patch v12-0008
- v12-0009-Convert-SLRUs-to-use-the-new-shmem-allocation-fu.patch (text/x-patch) patch v12-0009
- v12-0010-Convert-AIO-to-use-the-shmem-allocation-function.patch (text/x-patch) patch v12-0010
- v12-0011-Add-alignment-option-to-ShmemRequestStruct.patch (text/x-patch) patch v12-0011
- v12-0012-Convert-buffer-manager-to-the-new-shmem-allocati.patch (text/x-patch) patch v12-0012
- v12-0013-Convert-all-remaining-subsystems-to-use-the-new-.patch (text/x-patch) patch v12-0013
Here's patch version 12 [*]. I believe I've addressed all the feedback,
and I feel this is in pretty good shape now. There hasn't been any big
design changes lately.
One notable change is that I replaced the separate
{request|init|attach}_fn_arg fields in ShmemCallbacks with a single
'opaque_arg' field, and added a brief comment to it. You both commented
on whether we need that at all, and maybe you're right that we don't,
but at least it's now just one field rather than three. As before,
callers can simply ignore it if they don't need it.
[*] also available at
https://github.com/hlinnaka/postgres/tree/shmem-init-refactor-12
- Heikki
Commits
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Tidy up #ifdef USE_INJECTION_POINTS guards
- 9480c585df6c 19 (unreleased) landed
-
Convert all remaining subsystems to use the new shmem allocation API
- 9b5acad3f40f 19 (unreleased) landed
-
Convert buffer manager to use the new shmem allocation functions
- a4b6139dcceb 19 (unreleased) landed
-
Add alignment option to ShmemRequestStruct()
- dacfe81a0de5 19 (unreleased) landed
-
Convert AIO to use the new shmem allocation functions
- 58a1573385ed 19 (unreleased) landed
-
Convert SLRUs to use the new shmem allocation functions
- 2e0943a8597e 19 (unreleased) landed
-
Refactor shmem initialization code in predicate.c
- 4c9eca5afea0 19 (unreleased) landed
-
Use the new shmem allocation functions in a few core subsystems
- c6d55714ba4c 19 (unreleased) landed
-
Convert lwlock.c to use the new shmem allocation functions
- a006bc7b1699 19 (unreleased) landed
-
Introduce a registry of built-in shmem subsystems
- 1fc2e9fbc0a3 19 (unreleased) landed
-
Convert pg_stat_statements to use the new shmem allocation functions
- d4885af3d653 19 (unreleased) landed
-
Add a test module to test after-startup shmem allocations
- 6409994c7dd8 19 (unreleased) landed
-
Introduce a new mechanism for registering shared memory areas
- 283e823f9dcb 19 (unreleased) landed
-
Move some code from shmem.c and shmem.h
- 6ef9bee29310 19 (unreleased) landed
-
Improve test_lwlock_tranches
- 92a685e4070d 19 (unreleased) landed
-
Test pg_stat_statements across crash restart
- 148fe2b05df5 19 (unreleased) landed
-
Refactor PredicateLockShmemInit to not reuse var for different things
- 3fd057772827 19 (unreleased) landed
-
Refactor ShmemIndex initialization
- 6b8238cb6aa7 19 (unreleased) landed
-
Add a new shmem_request_hook hook.
- 4f2400cb3f10 15.0 cited