Re: pg_upgrade test writes to source directory
Andrew Dunstan <andrew@dunslane.net>
From: Andrew Dunstan <andrew@dunslane.net>
To: Michael Paquier <michael@paquier.xyz>, Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
Tom Lane <tgl@sss.pgh.pa.us>, Justin Pryzby <pryzby@telsasoft.com>,
pgsql-hackers@postgresql.org
Date: 2022-06-02T21:17:34Z
Lists: pgsql-hackers
On 2022-06-01 We 20:37, Michael Paquier wrote: > On Wed, Jun 01, 2022 at 02:11:12PM -0700, Andres Freund wrote: >> Until recently TESTDIR needed to point to the build directory containing the >> binaries. But I'd like to be able to separate test log output from the build >> tree, so that it's easier to capture files generated by tests for CI / >> buildfarm. The goal is to have a separate directory for each test, so we can >> present logs for failed tests separately. That was impossible with TESTDIR, >> because it needed to point to the build directory. > FWIW, this argument sounds sensible to me since I looked at 0001, not > only for the log files, but also to help in the capture of files > generated by the tests like 010_tab_completion.pl. > > I don't know yet what to do about this part, so for now I have fixed > the other issue reported by Peter where the test names were missing. I hope we fix the original issue soon - it's apparently been the cause of numerous buildfarm failures that it was on my list to investigate e.g. <https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jacana&dt=2022-05-15%2019%3A24%3A27> cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com
Commits
-
Split TESTDIR into TESTLOGDIR and TESTDATADIR
- c47885bd8b69 16.0 landed
-
Don't hardcode tmp_check/ as test directory for tap tests
- bb54bf22900f 16.0 landed
-
Force run of pg_upgrade in the build directory in its TAP test
- 15b6d2155375 15.0 landed
-
Add missing test names in TAP tests of pg_upgrade
- 99f6f19799ed 15.0 landed