Horton

Re: Add reject_limit option to file_fdw

torikoshia <torikoshia@oss.nttdata.com>

View thread View on postgr.es
From: torikoshia <torikoshia@oss.nttdata.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2024-11-12T01:16:50Z
Lists: pgsql-hackers

Attachments

On 2024-11-12 01:49, Fujii Masao wrote:
> On 2024/11/11 21:45, torikoshia wrote:
>>> Thanks for adding the comment. It clearly states that REJECT_LIMIT 
>>> can be
>>> a single-quoted string. However, it might also be helpful to mention 
>>> that
>>> it can be provided as an int64 in the COPY command option. How about
>>> updating it like this?
>>> 
>>> ------------------------------------
>>> REJECT_LIMIT can be specified in two ways: as an int64 for the COPY 
>>> command
>>> option or as a single-quoted string for the foreign table option 
>>> using
>>> file_fdw. Therefore this function needs to handle both formats.
>>> ------------------------------------
>> 
>> Thanks! it seems better.
>> 
>> 
>> Attached v3 patch.
> 
> Thanks for updating the patch! It looks like you forgot to attach it, 
> though.

Oops, thanks for pointing it out.
Here it is.


-- 
Regards,

--
Atsushi Torikoshi
Seconded from NTT DATA GROUP CORPORATION to SRA OSS K.K.

Commits

  1. file_fdw: Add regression tests for ON_ERROR and other options.

  2. file_fdw: Add REJECT_LIMIT option to file_fdw.