Thread

Re: Refactor: allow pg_strncoll(), etc., to accept -1 length for NUL-terminated cstrings.

Andres Freund <andres@anarazel.de> — 2026-05-14T22:17:17Z

Hi,

On 2026-05-05 13:23:12 -0700, Jeff Davis wrote:
> Agreed. I did this to match up with the ICU API a bit better, but if
> it's interfering with useful tools, then the special cases aren't worth
> it.

> Patch attached.

Thanks!


> It causes a bit of churn, so one disadvantage is that it will complicate
> future backports in this area.

I think it's worth the gain in instrument-ability.  I also suspect it's good
for runtime performance, adding all those branches can't be particularly good.


Greetings,

Andres Freund