Re: adding partitioned tables to publications

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

To: Amit Langote <amitlangote09@gmail.com>

Cc: Rafia Sabih <rafia.pghackers@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2019-11-11T12:48:57Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix RELCACHE_FORCE_RELEASE issue
- 12fb189bfeaf 13.0 landed
Allow publishing partition changes via ancestors
- 83fd4532a721 13.0 landed
Add logical replication support to replicate into partitioned tables
- f1ac27bfda6c 13.0 landed
Refactor code to look up local replication tuple
- d8653f468789 13.0 landed
Some refactoring of logical/worker.c
- 97ee604d9bce 13.0 landed
Prepare to support non-tables in publications
- c314c147c056 13.0 landed
Support adding partitioned tables to publication
- 17b9e7f9fe23 13.0 landed

On 2019-11-11 08:59, Amit Langote wrote:
> On Fri, Nov 8, 2019 at 1:27 PM Amit Langote <amitlangote09@gmail.com> wrote:
>> Anyway, I've attached two patches -- 0001 is a refactoring patch. 0002
>> implements the feature.
> 
> 0002 didn't contain necessary pg_dump changes, which fixed in the
> attached new version.

That looks more pleasant.

I don't understand why you go through great lengths to ensure that the 
relkinds match between publisher and subscriber.  We already ensure that 
only regular tables are published and only regular tables are allowed as 
subscription target.  In the future, we may want to allow further 
combinations.  What situation are you trying to address here?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services