Re: Logging which local address was connected to in log_line_prefix

David Steele <david@pgmasters.net>

From: David Steele <david@pgmasters.net>

To: Greg Sabino Mullane <htamfids@gmail.com>, Peter Eisentraut <peter@eisentraut.org>

Cc: Cary Huang <cary.huang@highgo.ca>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>

Date: 2024-07-08T07:07:16Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add local-address escape "%L" to log_line_prefix.
- 3516ea768c92 18.0 landed

On 5/24/24 22:33, Greg Sabino Mullane wrote:
> Peter, thank you for the feedback. Attached is a new patch with 
> "address" rather than "interface", plus a new default of "local" if 
> there is no address. I also removed the questionable comment, and 
> updated the commitfest title.

I tried the updated patch and it behaved as expected with [local] being 
logged for peer connections and an IP being logged for host connections.

One thing -- the changes in postgresql.conf.sample should use tabs to 
match the other lines. The patch uses spaces.

I also find the formatting in log_status_format() pretty awkward but I 
guess that will be handled by pgindent.

Regards,
-David