Horton

Thread

Commits

  1. Add parameter "connstr" to PostgreSQL::Test::Cluster::background_psql

  1. Custom connstr in background_psql()

    Aidar Imamov <a.imamov@postgrespro.ru> — 2024-09-17T22:08:26Z

    Hi, hackers!

I've noticed that there is no way to specify a custom connection string 
when
calling the PostgreSQL::Test::Cluster->background_psql() method compared 
to the
PostgreSQL::Test:Cluster->psql(). It seems useful to have this feature 
while
testing with BackgroundPsql, for example, when the default host value 
needs to
be overridden to establish different types of connections.

What do you think?

  2. Re: Custom connstr in background_psql()

    Michael Paquier <michael@paquier.xyz> — 2024-09-17T22:57:11Z

    On Wed, Sep 18, 2024 at 01:08:26AM +0300, a.imamov@postgrespro.ru wrote:
> I've noticed that there is no way to specify a custom connection string when
> calling the PostgreSQL::Test::Cluster->background_psql() method compared to the
> PostgreSQL::Test:Cluster->psql(). It seems useful to have this feature while
> testing with BackgroundPsql, for example, when the default host value needs
> to be overridden to establish different types of connections.
> 
> What do you think?

I think that it makes sense to extend the routine as you are
suggesting.  At least I can see myself using it depending on the test
suite I am dealing with.  So count me in.
--
Michael

  3. Re: Custom connstr in background_psql()

    Aidar Imamov <a.imamov@postgrespro.ru> — 2024-09-19T13:00:30Z

    Michael Paquier писал(а) 2024-09-18 01:57:
> On Wed, Sep 18, 2024 at 01:08:26AM +0300, a.imamov@postgrespro.ru 
> wrote:
>> I've noticed that there is no way to specify a custom connection 
>> string when
>> calling the PostgreSQL::Test::Cluster->background_psql() method 
>> compared to the
>> PostgreSQL::Test:Cluster->psql(). It seems useful to have this feature 
>> while
>> testing with BackgroundPsql, for example, when the default host value 
>> needs
>> to be overridden to establish different types of connections.
>> 
>> What do you think?
> 
> I think that it makes sense to extend the routine as you are
> suggesting.  At least I can see myself using it depending on the test
> suite I am dealing with.  So count me in.
> --
> Michael

Should I register the proposal in CF?
Which one to choose if so?

--
regards,
Aidar Imamov

  4. Re: Custom connstr in background_psql()

    Michael Paquier <michael@paquier.xyz> — 2024-09-19T22:53:13Z

    On Thu, Sep 19, 2024 at 04:00:30PM +0300, a.imamov@postgrespro.ru wrote:
> Should I register the proposal in CF?
> Which one to choose if so?

I think that's useful, so I'll just go apply it.
--
Michael