Re: Elimination of the repetitive code at the SLRU bootstrap functions.

Evgeny Voropaev <evorop.wiki@gmail.com>

From: Evgeny Voropaev <evorop.wiki@gmail.com>

To: Andrey Borodin <x4mmm@yandex-team.ru>, Evgeny <evorop@gmail.com>

Cc: Álvaro Herrera <alvherre@alvh.no-ip.org>, Evgeny Voropaev <evgeny.voropaev@tantorlabs.com>, Aleksander Alekseev <aleksander@timescale.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2025-03-12T15:02:07Z

Lists: pgsql-hackers

Attachments

v6-0001-Elimination-of-the-repetitive-code-at-the-SLRU-bo.patch (text/x-patch) patch v6-0001

Hello Hackers!

Andrey, thank you for your review and remarks.

 > Patch adds whitespace errors
Cleaned.

 > if (writePage != 0) should be if (writePage)
Done.

 > XLogSimpleInsert(int64 simpledata, RmgrId rmid, uint8 info)
 > I’d rename function XLogSimpleInsert() to something more descriptive
 > and changed arguments order from generic to specific.

The function has been renamed and the parameters have been reordered. 
Now we have:
     XLogInsertInt64(RmgrId rmid, uint8 info, int64 simpledata)

 > Probably, committer has broader view on XLog routines and can decide
 > if this function would better belong to SLRU than common XLog stuff.

In accordance with Álvaro's proposal, we want to enclose this function 
in the "xloginsert.c" module.

Best regards,
Evgeny Voropaev.