Re: pg_stat_statements and "IN" conditions

David Steele <david@pgmasters.net>

From: David Steele <david@pgmasters.net>

To: Zhihong Yu <zyu@yugabyte.com>, Dmitry Dolgov <9erthalion6@gmail.com>

Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>, Tom Lane <tgl@sss.pgh.pa.us>, Greg Stark <stark@mit.edu>, Pavel Trukhanov <pavel.trukhanov@gmail.com>

Date: 2021-03-18T13:38:09Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Introduce squashing of constant lists in query jumbling
- 62d712ecfd94 18.0 landed
Make documentation builds reproducible
- b0f0a9432d0b 17.0 cited
Include values of A_Const nodes in query jumbling
- 9ba37b2cb6a1 16.0 cited
Teach planner about more monotonic window functions
- 456fa635a909 16.0 cited
Split up guc.c for better build speed and ease of maintenance.
- 0a20ff54f5e6 16.0 cited

On 1/5/21 10:51 AM, Zhihong Yu wrote:
> 
> +   int         lastExprLenght = 0;
> 
> Did you mean to name the variable lastExprLenghth ?
> 
> w.r.t. extracting to helper method, the second and third 
> if (currentExprIdx == pgss_merge_threshold - 1) blocks are similar.
> It is up to you whether to create the helper method.
> I am fine with the current formation.

Dmitry, thoughts on this review?

Regards,
-- 
-David
david@pgmasters.net