Horton

Thread

Commits

  1. Shave some cycles off subscription/t/100_bugs.pl tests.

  1. Make a 100_bugs.pl test more faster.

    Anton A. Melnikov <aamelnikov@inbox.ru> — 2022-11-16T14:41:16Z

    Hello!

The previous discussion was here:
https://www.postgresql.org/message-id/flat/b570c367-ba38-95f3-f62d-5f59b9808226%40inbox.ru

>On 15.11.2022 04:59, Tom Lane wrote:
>> "Anton A. Melnikov" <aamelnikov@inbox.ru> writes:
>> 
>> Additionally
>> i've tried to reduce overall number of nodes previously
>> used in this test in a similar way.
> 
> Optimizing existing tests isn't an answer to that.  We could
> install those optimizations without adding a new test case.

Here is a separate patch for the node usage optimization mentioned above.
It decreases the CPU usage during 100_bugs.pl by about 30%.

There are also some experimental data: 100_bugs-CPU-usage.txt


Would be glad for any comments and concerns.

With best regards,

-- 
Anton A. Melnikov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

  2. Re: Make a 100_bugs.pl test more faster.

    Tom Lane <tgl@sss.pgh.pa.us> — 2022-11-16T17:37:46Z

    "Anton A. Melnikov" <aamelnikov@inbox.ru> writes:
> Here is a separate patch for the node usage optimization mentioned above.
> It decreases the CPU usage during 100_bugs.pl by about 30%.

Hmm ... as written, this isn't testing the same thing, because you
didn't disable the FOR ALL TABLES publications created in the earlier
steps, so we're redundantly syncing more publications in the later
ones.  Cleaning those up seems to make it a little faster yet,
so pushed with that adjustment.

			regards, tom lane