Horton

Re: Make all Perl warnings fatal

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2024-01-18T07:52:33Z
Lists: pgsql-hackers 
On 16.01.24 12:08, Bharath Rupireddy wrote:
> On Fri, Jan 12, 2024 at 9:21 PM Bharath Rupireddy
> <bharath.rupireddyforpostgres@gmail.com> wrote:
>>
>> On Fri, Jan 12, 2024 at 9:03 PM Peter Eisentraut <peter@eisentraut.org> wrote:
>>>
>>> I would put this code
>>>
>>>       my $core = $ret & 128 ? " (core dumped)" : "";
>>>       die "psql exited with signal "
>>>         . ($ret & 127)
>>>         . "$core: '$$stderr' while running '@psql_params'"
>>>         if $ret & 127;
>>>       $ret = $ret >> 8;
>>>
>>> inside a if (defined $ret) block.
>>>
>>> Then the behavior would be that the whole function returns undef on
>>> timeout, which is usefully different from returning 0 (and matches
>>> previous behavior).
>>
>> WFM.
> 
> I've attached a patch for the above change.

Committed, thanks.

Commits

  1. Add missing FATAL => 'all' to a use warnings in Perl

  2. Make all Perl warnings fatal in 043_wal_replay_wait.pl

  3. Add tap test for pg_signal_autovacuum role

  4. Implement pg_wal_replay_wait() stored procedure

  5. Fix an issue in PostgreSQL::Test::Cluster:psql()

  6. Make all Perl warnings fatal

  7. Fix a warning in Perl test code

  8. Avoid use of Perl getprotobyname