Horton

Re: PSA: we lack TAP test coverage on NetBSD and OpenBSD

Mikael Kjellström <mikael.kjellstrom@mksoft.nu>

View thread View on postgr.es
From: Mikael Kjellström <mikael.kjellstrom@mksoft.nu>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2019-01-17T23:46:45Z
Lists: pgsql-hackers 
On 2019-01-18 00:31, Tom Lane wrote:
> =?UTF-8?Q?Mikael_Kjellstr=c3=b6m?= <mikael.kjellstrom@mksoft.nu> writes:
>> And now also the NetBSD machine failed on pgbenchCheck.
> 
> Indeed, as expected.

Ok.


>> should I leave it as it is for now?
> 
> Please.  I'll push a fix for the broken test case in a bit --- I
> just wanted to confirm that somebody else's machines agreed that
> it's broken.

Ok, I will leave it on then.

/Mikael

Commits

  1. Fix portability problem in pgbench.

  2. Avoid assuming that we know the spelling of getopt_long's error messages.