Re: base backup client as auxiliary backend process

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

To: Andres Freund <andres@anarazel.de>

Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>, Sergei Kornilov <sk@zsrv.org>, Michael Paquier <michael@paquier.xyz>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2020-02-17T17:42:52Z

Lists: pgsql-hackers

Attachments

0001-pg_resetwal-Rename-function-to-avoid-potential-confl.patch (text/plain) patch 0001
0002-Reformat-code-comment.patch (text/plain) patch 0002
0003-Factor-out-InitControlFile-from-BootStrapXLOG.patch (text/plain) patch 0003

On 2020-02-03 13:47, Andres Freund wrote:
> Comment:
> 
> - It'd be good to split out the feature independent refactorings, like
>    the introduction of InitControlFile(), into their own commit. Right
>    now it's hard to separate out what should just should be moved code,
>    and what should be behavioural changes. Especially when there's stuff
>    like just reindenting comments as part of the patch.

Agreed.  Here are three refactoring patches extracted that seem useful 
on their own.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

Factor out InitControlFile() from BootStrapXLOG()
- 79c2385915dd 13.0 landed
Reformat code comment
- 9745f93afc56 13.0 landed
pg_resetwal: Rename function to avoid potential conflict
- 5f1b8260af96 13.0 landed
Expose PQbackendPID() through walreceiver API
- ee4ac46c8eb2 13.0 landed
walreceiver uses a temporary replication slot by default
- 329730827848 13.0 landed
Make lsn argument of walrcv_create_slot() optional
- c67a55da4ea0 13.0 landed
More precise errors from initial pg_control check
- b85e43feb3e8 13.0 landed