Re: PATCH: Batch/pipelining support for libpq
Daniel Verite <daniel@manitou-mail.org>
From: "Daniel Verite" <daniel@manitou-mail.org>
To: "Craig Ringer" <craig@2ndquadrant.com>
Cc: "Michael Paquier" <michael.paquier@gmail.com>,"Dmitry Igrishin"
<dmitigr@gmail.com>,"Andres Freund" <andres@anarazel.de>,"PostgreSQL
Hackers" <pgsql-hackers@postgresql.org>,"Manuel Kniep"
<m.kniep@web.de>,"fujita.etsuro@lab.ntt.co.jp"
<fujita.etsuro@lab.ntt.co.jp>
Date: 2016-09-06T08:10:08Z
Lists: pgsql-hackers
Attachments
- diff-typos.txt (text/plain)
Craig Ringer wrote:
> Updated patch attached.
Please find attached a couple fixes for typos I've came across in
the doc part.
Also it appears that PQqueriesInBatch() doesn't work as documented.
It says:
"Returns the number of queries still in the queue for this batch"
but in fact it's implemented as a boolean:
+/* PQqueriesInBatch
+ * Return true if there are queries currently pending in batch mode
+ */+int
+PQqueriesInBatch(PGconn *conn)
+{
+ if (!PQisInBatchMode(conn))
+ return false;
+
+ return conn->cmd_queue_head != NULL;
+}
However, is this function really needed? It doesn't seem essential to
the API. You don't call it in the test program either.
Best regards,
--
Daniel Vérité
PostgreSQL-powered mailer: http://www.manitou-mail.org
Twitter: @DanielVerite
Commits
-
Add libpq pipeline mode support to pgbench
- 9aa491abbf07 14.0 landed
-
Implement pipeline mode in libpq
- acb7e4eb6b1c 14.0 landed