Re: Doc: fix the rewrite condition when executing ALTER TABLE ADD COLUMN

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>
To: Álvaro Herrera <alvherre@alvh.no-ip.org>, Nathan Bossart <nathandbossart@gmail.com>
Cc: jian he <jian.universality@gmail.com>, Masahiro Ikeda <ikedamsh@oss.nttdata.com>, Robert Treat <rob@xzilla.net>, pgsql-hackers@lists.postgresql.org
Date: 2025-04-30T09:15:20Z
Lists: pgsql-hackers

Attachments

On 28.04.25 18:56, Álvaro Herrera wrote:
> On 2025-Apr-23, Nathan Bossart wrote:
> 
>> On Mon, Mar 24, 2025 at 11:37:20AM +0100, Álvaro Herrera wrote:
> 
>>> I'd add a note about these two things to the open items page, and wait
>>> to see if we get some of these limitations fixed, so that if we don't,
>>> we remember to note this limitation in the documentation.
>>
>> Are we still waiting on something for this, or should we proceed with the
>> documentation changes?  It doesn't seem tremendously urgent, but I noticed
>> it's been about a month since the last message on this thread.
> 
> I've edited the Open Items page to disclaim my responsibility from this
> item, since this comes from virtual generated columns which is not my
> turf.  I think we should just document the current state of affairs; we
> can come back with further code improvements during the next cycle.

Here is a proposed patch that includes some text about virtual generated 
columns and also fixes up a small mistake in the previous patch 
(confused identity and generated columns) and improves the wording and 
formatting a bit more.

Commits

  1. doc: Improve explanations when a table rewrite is needed

  2. doc: Explain more thoroughly when a table rewrite is needed

  3. Teach ALTER TABLE .. SET DATA TYPE to avoid some table rewrites.